PDA

View Full Version : Site bug...


dog_spawn
Jan 4th, 2005, 08:24 AM
Hi. This is a great site but there is a really annoying yet easy to fix problem:

Most of the links start with "http://http://"

:roll:

You should update the code to only add "http://" to the start of submitted URLs when actually needed.

Thanks :wink:

PS I hope this is the right place to post. I couldn't find a "Site bugs" sub-forum...

theFerf
Jan 4th, 2005, 12:29 PM
What you are seeing is a small bug, but not to the extent that you are thinking. When the podcasts are approved for use on the site the additional http:// is removed. When you do a search, it seaerches all podcasts (even ones that are not yet approved--the bug) and thats when you find that error.

I appreciate you pointing it out and allowing me to explain though.
Thanks. :)

dog_spawn
Jan 5th, 2005, 08:35 AM
I'll assume you are going to fix it then :)

What I would do is use regex to check the submitted URL is valid. This way any mistakes can be pointed out when the form is filled in.

As a (very shoddy) temporary fix, you could edit the page so that what users are supposed to type in is clear. Currently the advice should read

"Please do not include the http://"

Generally forms need pretty tight validation or you are just asking for trouble... (sql injection and cross site scripting)

PS the "add a postcast" page has a spelling mistake: "availalbe"